Add a filter slot to the dialog header #2804
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
This PR mirrors what we did recently for
Overlay
by adding a filter slot. The idea is the consumer will render a text field in here (or other filtering mechanism) as we're doing for the experimentalSelectPanel
component being developed in dotcom. I specifically need this functionality because I'm trying to render aSelectPanel
inside aDialog
and need theDialog
to support the same API asSelectPanel
andOverlay
(sinceSelectPanel
s are also rendered insideOverlay
s).Screenshots
Integration
No changes necessary in production.
Risk Assessment
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.