Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filter slot to the dialog header #2804

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Add a filter slot to the dialog header #2804

merged 3 commits into from
Apr 24, 2024

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Apr 24, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

This PR mirrors what we did recently for Overlay by adding a filter slot. The idea is the consumer will render a text field in here (or other filtering mechanism) as we're doing for the experimental SelectPanel component being developed in dotcom. I specifically need this functionality because I'm trying to render a SelectPanel inside a Dialog and need the Dialog to support the same API as SelectPanel and Overlay (since SelectPanels are also rendered inside Overlays).

Screenshots

A screenshot of a Primer Dialog component showing a text field rendered as part of the header.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 1a0bbb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants