Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert tab container upgrade" #2855

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

keithamus
Copy link
Member

@keithamus keithamus commented May 20, 2024

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Reverts #2839 which reverted #2624.

Let's try to get tab-container released again.

Integration

Some production changes required (see https://github.com/github/github/pull/325362)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

@keithamus keithamus requested review from a team as code owners May 20, 2024 13:53
@keithamus keithamus requested review from langermank and removed request for a team May 20, 2024 13:53
Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: 0539acd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@keithamus keithamus merged commit 05159ca into main Jun 10, 2024
31 checks passed
@keithamus keithamus deleted the revert-2839-revert_tab_container_upgrade branch June 10, 2024 09:53
@primer primer bot mentioned this pull request Jun 7, 2024
camertron added a commit that referenced this pull request Jun 21, 2024
@camertron camertron restored the revert-2839-revert_tab_container_upgrade branch June 21, 2024 16:39
@camertron camertron deleted the revert-2839-revert_tab_container_upgrade branch June 21, 2024 16:43
@camertron
Copy link
Contributor

camertron commented Jun 21, 2024

Sadly we had to revert this again 😢 It caused several rollbacks and at least one production bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants