[Alpha][SelectPanel] Fix single select remote loading bug

[kendallgassner]

What

Fixes a remote single-select filtering has a bug where ...

When a user clicks an item handleItemActivated is called. In single select mode this function de-selects all items stored in this.items.

However, this.items contains only SelectPanel items that the server has returned to the SelectPanel. Meaning, if a user filters items using the input field the server may have returned a subset of items and therefore, we cannot deselect all items.

A similar problem will occur if a server has a limit and only returns a subset of the results to begin with.

Additionally, I fixed removeSelecteditems as it was checking for the data-value on the li as opposed to the button which has the actual value.

List the issues that this change affects.

• https://github.com/github/primer/issues/3694

Closes # (type the GitHub issue number after #)

• https://github.com/github/primer/issues/3694

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Added test cases to test functionality and mitgate regression

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 7e39d8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[camertron]

🎉