Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "action" to the list of data attributes that accept multiple values #3076

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Sep 10, 2024

What are you trying to accomplish?

The current attribtue helper method merge_data has defined some keys that accept multiple values and adds some after each other devided by a space. This PR adds action to the list of the allowed keys.

Integration

No

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@HDinger HDinger requested a review from a team as a code owner September 10, 2024 13:30
Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: 39dec4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HDinger
Copy link
Contributor Author

HDinger commented Oct 1, 2024

Hey folks :) Any feedback on this?

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Nice catch!

@HDinger
Copy link
Contributor Author

HDinger commented Oct 11, 2024

@keithamus Can we merge this then?

@keithamus keithamus merged commit 7e7a60f into primer:main Oct 11, 2024
38 checks passed
@primer primer bot mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants