Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prove command api #60

Closed
5 tasks done
0xmad opened this issue Apr 11, 2024 · 1 comment · Fixed by privacy-scaling-explorations/maci#1451
Closed
5 tasks done

Support prove command api #60

0xmad opened this issue Apr 11, 2024 · 1 comment · Fixed by privacy-scaling-explorations/maci#1451
Assignees
Labels
enhancement New feature or request

Comments

@0xmad
Copy link
Collaborator

0xmad commented Apr 11, 2024

  • Support prove command cli for coordinator service
  • Make sure all inputs are sanitized
  • Download zkey files for the service
  • Support coordinator key encryption to prevent storing private data inside the service
  • Support prove configuration params
@0xmad 0xmad added this to MACI Apr 11, 2024
@0xmad 0xmad converted this from a draft issue Apr 11, 2024
@0xmad 0xmad added the enhancement New feature or request label Apr 11, 2024
@kittybest
Copy link
Contributor

To add more details for "Make sure all inputs are sanitized":
make sure the private key input is valid: take public from contract https://github.com/privacy-scaling-explorations/maci/blob/dev/contracts/contracts/Poll.sol#L25
create keypair from coordinator private key, check public key match

this is because the error generated by using wrong private key is hard to understand, and I am not sure if the same error also displayed in other cases, so I think it's better to check the keypairs first.

An unexpected error occurred:

AssertionError [ERR_ASSERTION]: false == true
    at genMaciStateFromContract (/home/user/Documents/maci/contracts/ts/genMaciState.ts:156:9)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async SimpleTaskDefinition.action (/home/user/Documents/maci/contracts/tasks/runner/prove.ts:127:25)
    at async Environment._runTaskDefinition (/home/user/Documents/maci/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/hardhat/src/internal/core/runtime-environment.ts:359:14)
    at async Environment.run (/home/user/Documents/maci/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/hardhat/src/internal/core/runtime-environment.ts:192:14)
    at async main (/home/user/Documents/maci/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/hardhat/src/internal/cli/cli.ts:323:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants