Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coordinator): add crypto and proof generation services #1424

Merged
merged 1 commit into from
May 4, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented May 3, 2024

Description

  • Add key generation script
  • Add crypto service
  • Add proof generation service
  • Add launch instructions and code docs

Additional Notes

Auth-z, controller and e2e tests are not implemented yet, but will be added in next PRs.
Current PR has atomic change for maci-coordinator package and doesn't affect anything.

Related issue(s)

Related to privacy-scaling-explorations/maci-platform#60

Confirmation

@0xmad 0xmad added the enhancement New feature or request label May 3, 2024
@0xmad 0xmad self-assigned this May 3, 2024
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview May 3, 2024 8:35pm

@0xmad 0xmad force-pushed the feature/proof-generation branch from 6da2e1b to 4d8958d Compare May 3, 2024 18:39
@0xmad 0xmad marked this pull request as draft May 3, 2024 18:43
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just leaving some comments in the meantime that this is ready, great work so far though

coordinator/.env.example Show resolved Hide resolved
coordinator/.env.example Show resolved Hide resolved
coordinator/ts/proof/proof.service.ts Outdated Show resolved Hide resolved
- [x] Add key generation script
- [x] Add crypto service
- [x] Add proof generation service
- [x] Add launch instructions and code docs
@0xmad 0xmad force-pushed the feature/proof-generation branch from 597041e to 6c9891e Compare May 3, 2024 20:33
@0xmad 0xmad marked this pull request as ready for review May 3, 2024 20:36
@0xmad 0xmad requested a review from ctrlc03 May 3, 2024 20:36
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ctrlc03 ctrlc03 merged commit 553995a into dev May 4, 2024
20 checks passed
@ctrlc03 ctrlc03 deleted the feature/proof-generation branch May 4, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants