fix(poll.sol,maci.sol): protect messageAq by nothing up my sleeve hash

add nothing up my sleeve number into the leaf zero in message queue
privacy-scaling-explorations · Sep 13, 2022 · 04f21b3 · 04f21b3
1 parent ee0c8a6
commit 04f21b3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/contracts/contracts/MACI.sol b/contracts/contracts/MACI.sol
@@ -34,11 +34,6 @@ contract MACI is IMACI, DomainObjs, Params, SnarkCommon, Ownable {
     uint8 internal constant STATE_TREE_ARITY = 5;
     uint8 internal constant MESSAGE_TREE_ARITY = 5;
 
-    // The Keccack256 hash of 'Maci'
-    uint256 internal constant NOTHING_UP_MY_SLEEVE =
-        uint256(
-            8370432830353022751713833565135785980866757267633941821328460903436894336785
-        );
 
     //// The hash of a blank state leaf
     uint256 internal constant BLANK_STATE_LEAF_HASH =

diff --git a/contracts/contracts/Poll.sol b/contracts/contracts/Poll.sol
@@ -44,6 +44,13 @@ contract PollFactory is
     Hasher,
     PollDeploymentParams
 {
+
+    // The Keccack256 hash of 'Maci'
+    uint256 internal constant NOTHING_UP_MY_SLEEVE =
+        uint256(
+            8370432830353022751713833565135785980866757267633941821328460903436894336785
+        );
+
     MessageAqFactory public messageAqFactory;
 
     function setMessageAqFactory(MessageAqFactory _messageAqFactory)
@@ -91,6 +98,7 @@ contract PollFactory is
         AccQueue messageAq = messageAqFactory.deploy(
             _treeDepths.messageTreeSubDepth
         );
+        messageAq.enqueue(NOTHING_UP_MY_SLEEVE);
 
         ExtContracts memory extContracts;