refactor(deploy-task): fixed recommendations

privacy-scaling-explorations · Jun 5, 2024 · 3cc00dc · 3cc00dc
1 parent bea57e0
commit 3cc00dc
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/contracts/package.json b/contracts/package.json
@@ -76,7 +76,6 @@
     "@nomicfoundation/hardhat-toolbox": "^5.0.0",
     "@openzeppelin/contracts": "^5.0.2",
     "@zk-kit/imt.sol": "2.0.0-beta.12",
-    "buffer": "^6.0.3",
     "circomlibjs": "^0.1.7",
     "ethers": "^6.12.1",
     "hardhat": "^2.22.4",

diff --git a/contracts/tasks/deploy/maci/02-gatekeepers.ts b/contracts/tasks/deploy/maci/02-gatekeepers.ts
@@ -126,7 +126,7 @@ deployment.deployTask("full:deploy-gatekeepers", "Deploy gatekeepers").then((tas
       const validSigner2 = deployment.getDeployConfigField<string>(EContracts.ZupassGatekeeper, "signer2", true);
       let verifier: string | undefined = deployment.getDeployConfigField<string>(
         EContracts.ZupassGatekeeper,
-        "groth16Verifier",
+        "zupassVerifier",
       );
       if (!verifier) {
         const verifierContract = await deployment.deployContract({

diff --git a/contracts/tasks/deploy/maci/08-maci.ts b/contracts/tasks/deploy/maci/08-maci.ts
@@ -74,18 +74,15 @@ deployment.deployTask("full:deploy-maci", "Deploy MACI contract").then((task) =>
       const maciInstanceAddress = await maciContract.getAddress();
 
       await gatekeeperContract.setMaciInstance(maciInstanceAddress).then((tx) => tx.wait());
-    }
-
-    if (gatekeeper === EContracts.GitcoinPassportGatekeeper) {
+    } else if (gatekeeper === EContracts.GitcoinPassportGatekeeper) {
       const gatekeeperContract = await deployment.getContract<GitcoinPassportGatekeeper>({
         name: EContracts.GitcoinPassportGatekeeper,
         address: gatekeeperContractAddress,
       });
       const maciInstanceAddress = await maciContract.getAddress();
 
       await gatekeeperContract.setMaciInstance(maciInstanceAddress).then((tx) => tx.wait());
-    }
-    if (gatekeeper === EContracts.ZupassGatekeeper) {
+    } else if (gatekeeper === EContracts.ZupassGatekeeper) {
       const gatekeeperContract = await deployment.getContract<ZupassGatekeeper>({
         name: EContracts.ZupassGatekeeper,
         address: gatekeeperContractAddress,

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml