chore(contract): apply linter for deploy scripts and contracts

- [x] Update hardhat, ethers and add @nomicfoundation/hardhat-toolbox
- [x] Linter fixes for deploy scripts
- [x] Prettier fixes for solidity contracts
- [x] Optimize e2e workflow
- [x] Fixes for cli and integrations tests due to contracts dependency update
- [x] Type fixes

.eslintignore

@@ -1,4 +1,6 @@
 node_modules
 dist
 coverage
-build
+build
+typechain-types
+.eslintrc.js

.github/workflows/checks.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        command: ["prettier", "lint"]
+        command: ["prettier", "lint:ts"]
 
     runs-on: ubuntu-22.04
 

.github/workflows/reusable-e2e.yml

@@ -5,6 +5,11 @@ on:
 
 jobs:
   e2e:
+    strategy:
+      fail-fast: false
+      matrix:
+        command: ["test:cli", "test:integration"]
+
     runs-on: ubuntu-22.04
 
     steps:
@@ -53,7 +58,6 @@ jobs:
       - name: Compile Contracts
         run: |
           cd contracts
-          npm run compileSol
           npm run hardhat &
           sleep 5
 
@@ -84,15 +88,8 @@ jobs:
           cd integrationTests
           npm run download-zkeys
 
-      - name: Bespoke Test
-        run: |
-          cd cli
-          npm run test
-
-      - name: Integration Test
-        run: |
-          cd integrationTests
-          npm run test
+      - name: ${{ matrix.command }}
+        run: npm run ${{ matrix.command }}
 
       - name: Stop Hardhat
         run: kill $(lsof -t -i:8545)

.gitignore

@@ -27,6 +27,7 @@ contracts/artifacts
 contracts/compiled
 cli/cache
 contracts/cache
+typechain-types/
 
 node_modules
 blake2sdef.json

.lintstagedrc.json

@@ -1,4 +1,4 @@
 {
-  "**/*.ts": ["prettier --ignore-unknown --write", "eslint --fix"],
-  "**/*.{sol, yaml, yml, md}": ["prettier --ignore-unknown --write"]
+  "**/*.{ts,js}": ["prettier --ignore-unknown --write", "eslint --fix"],
+  "**/*.{sol, yaml, yml, md, json}": ["prettier --ignore-unknown --write"]
 }

.prettierignore

@@ -8,3 +8,4 @@ package-lock.json
 **/package-lock.json
 CHANGELOG.md
 .eslintignore
+circuits/ts/verifier_groth16.sol

.prettierrc

@@ -1,4 +1,5 @@
 {
+  "plugins": ["prettier-plugin-solidity"],
   "arrowParens": "always",
   "bracketSpacing": true,
   "endOfLine": "lf",
@@ -13,6 +14,8 @@
       "files": "*.sol",
       "options": {
         "printWidth": 120,
+        "useTabs": false,
+        "singleQuote": false,
         "semi": true
       }
     }

.solhint.json

@@ -0,0 +1,11 @@
+{
+  "extends": "solhint:recommended",
+  "rules": {
+    "avoid-suicide": "error",
+    "avoid-sha3": "warn",
+    "max-line-length": ["warn", 120],
+    "quotes": ["error", "single"],
+    "func-visibility": ["error", { "ignoreConstructors": true }],
+    "state-visibility": "error"
+  }
+}

circuits/package.json

@@ -29,7 +29,7 @@
   },
   "devDependencies": {
     "@types/chai": "^4.3.11",
-    "@types/mocha": "^10.0.4",
+    "@types/mocha": "^10.0.6",
     "@types/node": "^18.11.9",
     "chai": "^4.3.10",
     "circom_tester": "^0.0.20",

cli/hardhat.config.ts

@@ -0,0 +1,25 @@
+import type { HardhatUserConfig } from "hardhat/config";
+import "@nomicfoundation/hardhat-toolbox";
+
+import path from "path";
+
+import { DEFAULT_ETH_SK, DEFAULT_ETH_PROVIDER } from "./ts/utils/defaults";
+
+const parentDir = __dirname.includes("build") ? ".." : "";
+
+const config: HardhatUserConfig = {
+  defaultNetwork: "localhost",
+  networks: {
+    localhost: {
+      url: process.env.ETH_PROVIDER || DEFAULT_ETH_PROVIDER,
+      accounts: [process.env.ETH_SK || DEFAULT_ETH_SK],
+      loggingEnabled: false,
+    },
+  },
+  paths: {
+    sources: path.resolve(__dirname, parentDir, "../contracts/contracts"),
+    artifacts: path.resolve(__dirname, parentDir, "../contracts/artifacts"),
+  },
+};
+
+export default config;