-
Notifications
You must be signed in to change notification settings - Fork 153
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -182,7 +182,10 @@ contract Poll is Params, Utilities, SnarkCommon, IPoll { | |
/// @dev Can only be submitted before the voting deadline | ||
/// @param _messages the messages | ||
/// @param _encPubKeys the encrypted public keys | ||
function publishMessageBatch(Message[] calldata _messages, PubKey[] calldata _encPubKeys) external { | ||
function publishMessageBatch( | ||
Message[] calldata _messages, | ||
Check warning Code scanning / Slither Conformance to Solidity naming conventions Warning
Parameter Poll.publishMessageBatch(DomainObjs.Message[],DomainObjs.PubKey[])._messages is not in mixedCase
|
||
PubKey[] calldata _encPubKeys | ||
Check warning Code scanning / Slither Conformance to Solidity naming conventions Warning
Parameter Poll.publishMessageBatch(DomainObjs.Message[],DomainObjs.PubKey[])._encPubKeys is not in mixedCase
|
||
) public virtual isWithinVotingDeadline { | ||
if (_messages.length != _encPubKeys.length) { | ||
revert InvalidBatchLength(); | ||
} | ||
|
@@ -199,7 +202,7 @@ contract Poll is Params, Utilities, SnarkCommon, IPoll { | |
} | ||
|
||
/// @inheritdoc IPoll | ||
function mergeMaciState() public isAfterVotingDeadline { | ||
function mergeMaciState() public virtual isAfterVotingDeadline { | ||
// This function can only be called once per Poll after the voting | ||
// deadline | ||
if (stateMerged) revert StateAlreadyMerged(); | ||
|
@@ -234,13 +237,13 @@ contract Poll is Params, Utilities, SnarkCommon, IPoll { | |
} | ||
|
||
/// @inheritdoc IPoll | ||
function mergeMessageAqSubRoots(uint256 _numSrQueueOps) public isAfterVotingDeadline { | ||
function mergeMessageAqSubRoots(uint256 _numSrQueueOps) public virtual isAfterVotingDeadline { | ||
Check warning Code scanning / Slither Conformance to Solidity naming conventions Warning
Parameter Poll.mergeMessageAqSubRoots(uint256)._numSrQueueOps is not in mixedCase
|
||
extContracts.messageAq.mergeSubRoots(_numSrQueueOps); | ||
emit MergeMessageAqSubRoots(_numSrQueueOps); | ||
} | ||
Check notice Code scanning / Slither Reentrancy vulnerabilities Low
Reentrancy in Poll.mergeMessageAqSubRoots(uint256):
External calls: - extContracts.messageAq.mergeSubRoots(_numSrQueueOps) Event emitted after the call(s): - MergeMessageAqSubRoots(_numSrQueueOps) |
||
|
||
/// @inheritdoc IPoll | ||
function mergeMessageAq() public isAfterVotingDeadline { | ||
function mergeMessageAq() public virtual isAfterVotingDeadline { | ||
uint256 root = extContracts.messageAq.merge(treeDepths.messageTreeDepth); | ||
emit MergeMessageAq(root); | ||
} | ||
Check notice Code scanning / Slither Reentrancy vulnerabilities Low
Reentrancy in Poll.mergeMessageAq():
External calls: - root = extContracts.messageAq.merge(treeDepths.messageTreeDepth) Event emitted after the call(s): - MergeMessageAq(root) |
||
|