chore: optimize message processing circuits

privacy-scaling-explorations · Dec 3, 2024 · d5b170b · d5b170b
1 parent 108750f
commit d5b170b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 26 deletions.
diff --git a/packages/circuits/circom/core/non-qv/processMessages.circom b/packages/circuits/circom/core/non-qv/processMessages.circom
@@ -379,11 +379,6 @@ template ProcessOneNonQv(stateTreeDepth, voteOptionTreeDepth) {
 
     // 5. Verify that currentVoteWeight exists in the ballot's vote option root
     // at cmdVoteOptionIndex.
-    var voiceCreditAmountValid = SafeGreaterEqThan(252)([
-        stateLeaf[STATE_LEAF_VOICE_CREDIT_BALANCE_IDX] + currentVoteWeight,
-        cmdNewVoteWeight
-    ]);
-
     var cmdVoteOptionIndexMux = Mux1()([0, cmdVoteOptionIndex], computedIsVoteOptionIndexValid);
     var computedCurrentVoteWeightPathIndices[voteOptionTreeDepth] = QuinGeneratePathIndices(voteOptionTreeDepth)(cmdVoteOptionIndexMux);
 
@@ -396,17 +391,10 @@ template ProcessOneNonQv(stateTreeDepth, voteOptionTreeDepth) {
     computedCurrentVoteWeightQip === ballot[BALLOT_VO_ROOT_IDX];
 
     var voteWeightMux = Mux1()([currentVoteWeight, cmdNewVoteWeight], computedIsValid);
-    var newSlVoiceCreditBalanceMux = Mux1()(
-        [
-            stateLeaf[STATE_LEAF_VOICE_CREDIT_BALANCE_IDX],
-            stateLeaf[STATE_LEAF_VOICE_CREDIT_BALANCE_IDX] + currentVoteWeight - cmdNewVoteWeight
-        ],
-        voiceCreditAmountValid
-    );
     var voiceCreditBalanceMux = Mux1()(
         [
             stateLeaf[STATE_LEAF_VOICE_CREDIT_BALANCE_IDX],
-            newSlVoiceCreditBalanceMux
+            stateLeaf[STATE_LEAF_VOICE_CREDIT_BALANCE_IDX] + currentVoteWeight - cmdNewVoteWeight
         ],
         computedIsValid
     );

diff --git a/packages/circuits/circom/core/qv/processMessages.circom b/packages/circuits/circom/core/qv/processMessages.circom
@@ -382,11 +382,6 @@ template ProcessOne(stateTreeDepth, voteOptionTreeDepth) {
     currentVoteWeightSquare <== currentVoteWeight * currentVoteWeight;
     cmdNewVoteWeightSquare <== cmdNewVoteWeight * cmdNewVoteWeight;
 
-    var voiceCreditAmountValid = SafeGreaterEqThan(252)([
-        stateLeaf[STATE_LEAF_VOICE_CREDIT_BALANCE_IDX] + currentVoteWeightSquare,
-        cmdNewVoteWeightSquare
-    ]);
-
     var cmdVoteOptionIndexMux = Mux1()([0, cmdVoteOptionIndex], computedIsVoteOptionIndexValid);
     var computedCurrentVoteWeightPathIndices[voteOptionTreeDepth] = QuinGeneratePathIndices(voteOptionTreeDepth)(cmdVoteOptionIndexMux);
 
@@ -399,17 +394,10 @@ template ProcessOne(stateTreeDepth, voteOptionTreeDepth) {
     computedCurrentVoteWeightQip === ballot[BALLOT_VO_ROOT_IDX];
 
     var voteWeightMux = Mux1()([currentVoteWeight, cmdNewVoteWeight], computedIsValid);
-    var newSlVoiceCreditBalanceMux = Mux1()(
-        [
-            stateLeaf[STATE_LEAF_VOICE_CREDIT_BALANCE_IDX],
-            stateLeaf[STATE_LEAF_VOICE_CREDIT_BALANCE_IDX] + currentVoteWeightSquare - cmdNewVoteWeightSquare
-        ],
-        voiceCreditAmountValid
-    );
     var voiceCreditBalanceMux = Mux1()(
         [
             stateLeaf[STATE_LEAF_VOICE_CREDIT_BALANCE_IDX],
-            newSlVoiceCreditBalanceMux
+            stateLeaf[STATE_LEAF_VOICE_CREDIT_BALANCE_IDX] + currentVoteWeightSquare - cmdNewVoteWeightSquare
         ],
         computedIsValid
     );