fix: minor type issue for @zk-kit/eddsa-poseidon

privacy-scaling-explorations · Mar 29, 2024 · ee81309 · ee81309
1 parent cca4446
commit ee81309
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/crypto/ts/keys.ts b/crypto/ts/keys.ts
@@ -25,7 +25,7 @@ export const genRandomSalt = (): bigint => genRandomBabyJubValue();
  * @param privKey A private key generated using genPrivKey()
  * @returns A BabyJub-compatible private key.
  */
-export const formatPrivKeyForBabyJub = (privKey: PrivKey): bigint => BigInt(deriveSecretScalar(privKey));
+export const formatPrivKeyForBabyJub = (privKey: PrivKey): bigint => BigInt(deriveSecretScalar(privKey.toString()));
 
 /**
  * Losslessly reduces the size of the representation of a public key
@@ -49,7 +49,7 @@ export const unpackPubKey = (packed: bigint): PubKey => {
  * @returns A public key associated with the private key
  */
 export const genPubKey = (privKey: PrivKey): PubKey => {
-  const key = derivePublicKey(privKey);
+  const key = derivePublicKey(privKey.toString());
   return [BigInt(key[0]), BigInt(key[1])];
 };
 

diff --git a/domainobjs/ts/commands/PCommand.ts b/domainobjs/ts/commands/PCommand.ts
@@ -139,7 +139,7 @@ export class PCommand implements ICommand {
   /**
    * @notice Signs this command and returns a Signature.
    */
-  sign = (privKey: PrivKey): Signature => sign(privKey.rawPrivKey, this.hash());
+  sign = (privKey: PrivKey): Signature => sign(privKey.rawPrivKey.toString(), this.hash());
 
   /**
    * @notice Returns true if the given signature is a correct signature of this