Simplify circuit parameter configuration by always deriving MaxValues and BatchSizes from TreeDepths

[yuetloo]

Prerequisites

Please answer the following question for yourself before submitting a feature request.

• I checked to make sure that this request has not already been filed

Motivation

Currently, to use these circuits from the ceremony,

tallyVotes_6-2-3
processMessage_6-8-2-3

applications (e.g clr.fund) have to pass the derivable data

1. MaxValues to maci.deployPoll()
2. messageBatchSize to VKRegistry

Change request:

1. remove MaxValues from deployPoll() interface and let MACI calculate it
2. replace messageBatchSize with messageTreeSubDepth in VKRegistry and MessageProcessor

The intent is to minimize inconsistency and error in applications passing the wrong messageBatchSize or MaxValues to MACI.

  function deployPoll(
    uint256 _duration,
    MaxValues memory _maxValues,
    TreeDepths memory _treeDepths,
    PubKey memory _coordinatorPubKey,
    address _verifier,
    address _vkRegistry,
    bool useSubsidy
  ) 

  function setVerifyingKeys(
    uint256 _stateTreeDepth,
    uint256 _intStateTreeDepth,
    uint256 _messageTreeDepth,
    uint256 _voteOptionTreeDepth,
    uint256 _messageBatchSize,
    VerifyingKey calldata _processVk,
    VerifyingKey calldata _tallyVk
  )

Details

Please describe your feature request in detail.

Make sure that you have reviewed MACI's Contributor Guidelines