Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log exception from poll.processMessage() #1135

Closed
1 task done
yuetloo opened this issue Jan 30, 2024 · 0 comments · Fixed by #1138
Closed
1 task done

Log exception from poll.processMessage() #1135

yuetloo opened this issue Jan 30, 2024 · 0 comments · Fixed by #1138
Assignees

Comments

@yuetloo
Copy link
Contributor

yuetloo commented Jan 30, 2024

Prerequisites

Please answer the following question for yourself before submitting a feature request.

  • I checked to make sure that this request has not already been filed

Motivation

If the exception from poll.processMessage() is logged when the quiet flag is off, it will help debugging.

https://github.com/privacy-scaling-explorations/maci/blob/dev/core/ts/Poll.ts#L326-L333

    } catch (e) {
      if (e instanceof ProcessMessageError) {
        throw e;
      } else {
        throw new ProcessMessageError(ProcessMessageErrors.FailedDecryption);
      }
    }
  };

Details

Please describe your feature request in detail.

Make sure that you have reviewed MACI's Contributor Guidelines

@ctrlc03 ctrlc03 self-assigned this Jan 31, 2024
@ctrlc03 ctrlc03 added this to MACI Jan 31, 2024
@ctrlc03 ctrlc03 moved this to In Progress in MACI Jan 31, 2024
ctrlc03 added a commit that referenced this issue Jan 31, 2024
allow to log errors in message processing by accepting a flag into core.processMessages

fix #1135
@github-project-automation github-project-automation bot moved this from In Progress to Done in MACI Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants