Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate constraints on process message circuit #305

Closed
corydickson opened this issue Nov 12, 2021 · 0 comments · Fixed by #1644
Closed

Duplicate constraints on process message circuit #305

corydickson opened this issue Nov 12, 2021 · 0 comments · Fixed by #1644
Assignees
@ctrlc03
Labels
circuits Related to the Circom circuits enhancement New feature or request

Comments

@corydickson
Copy link
Contributor

The circuit which process messages contains a duplicate check for the constraint, enoughVoiceCredits which is initially validated in the messageValidator circuit.

Therefore this should be removed when processing each message since we assume the message is already valid, having the appropriate number of voice credits
@corydickson corydickson added enhancement New feature or request v1.0.0 labels Nov 12, 2021
@ctrlc03 ctrlc03 removed the v1.0.0 label Nov 17, 2023
@ctrlc03 ctrlc03 added the circuits Related to the Circom circuits label Dec 15, 2023
@ctrlc03 ctrlc03 self-assigned this Jul 15, 2024
@ctrlc03 ctrlc03 added this to MACI Jul 15, 2024
@ctrlc03 ctrlc03 moved this to In Progress in MACI Jul 15, 2024
@ctrlc03 ctrlc03 mentioned this issue Jul 15, 2024
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in MACI Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctrlc03 ctrlc03

Labels
circuits Related to the Circom circuits enhancement New feature or request
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(circuits): remove duplicate constraints privacy-scaling-explorations/maci
2 participants
@corydickson @ctrlc03