refactor(circuits): remove duplicate constraints #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kittybest
reviewed
Jul 15, 2024
circuits/circom/utils/non-qv/stateLeafAndBallotTransformer.circom
Outdated
Show resolved
Hide resolved
circuits/circom/utils/non-qv/stateLeafAndBallotTransformer.circom
Outdated
Show resolved
Hide resolved
ctrlc03
force-pushed
the
refactor/optimize-circuits
branch
from
597341c to
fd215a7
Compare
0xmad
approved these changes
Jul 15, 2024
ctrlc03
force-pushed
the
refactor/optimize-circuits
branch
from
fd215a7 to
8ea6c5b
Compare
ctrlc03
force-pushed
the
refactor/optimize-circuits
branch
from
8ea6c5b to
52c9711
Compare
ctrlc03
force-pushed
the
refactor/optimize-circuits
branch
from
52c9711 to
a9300d0
Compare
ctrlc03
force-pushed
the
refactor/optimize-circuits
branch
from
a9300d0 to
69d31e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove duplicate constraints on circuits by re-using signals and removing unnecessary checks.
Related issue(s)
fix #305
Confirmation