New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MACI: Return values of transferFrom calls are not checked #505

Closed

baumstern opened this issue Aug 25, 2022 · 0 comments · Fixed by #522

Member

baumstern commented Aug 25, 2022

Points: 3

baumstern added the 3 label

ctrlc03 added a commit to ctrlc03/maci that referenced this issue


          fix(maci, poll, vkregistry, accqueue): implemented fixes for audit fi…

53c5e58

…ndings on MACI

Implemented fixes for audit findings on MACI, Poll, VkRegistry and AccQueue. 1. Fixed possible
reentrancy attacks. 2. Moved around error messages to reflect the correct error condition.  3.
changed storage variables outside of loops to reduce gas costs. 4. Added SafeERC20 to check a
transfer's return value. 5. Removed redundant boolean checks. 6. Using return value of
`maci.mergeStateAq` to update the `mergedStateRoot` variable.

fix privacy-scaling-explorations#503 fix privacy-scaling-explorations#504 fix privacy-scaling-explorations#505 fix privacy-scaling-explorations#508 fix privacy-scaling-explorations#510

ctrlc03 added a commit to ctrlc03/maci that referenced this issue


          fix(maci): implemented fixes for several audit issues

6f1fa85

1. Implemented fixes for possible reentrancy attacks.
 2. Ameneded error messages in `Poll` and
`PollyProcesorAndTallyer`.
 3. Introduced local variable in `AccQueue` to prevent updating state
variables in a for loop.
 4. Removed redundant boolean comparisons.
 5. Added `SafeERC20` to
`Poll` to check the return value of `transferFrom`.

fix privacy-scaling-explorations#503 fix privacy-scaling-explorations#504 fix privacy-scaling-explorations#505 fix privacy-scaling-explorations#508 fix privacy-scaling-explorations#510

ctrlc03 mentioned this issue

Fix/audit (Implementing fixes for audit issues) #522

Merged

ctrlc03 linked a pull request

that will close this issue

Fix/audit (Implementing fixes for audit issues) #522

Merged

ctrlc03 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment