Resolve redundancy of contract deployment

[baumstern]

    TODO: resolve redundacy

Originally posted by @gurrpi in #553 (comment)

[ctrlc03]

Good shout, although I found that in between txs I had to pull fresh gas fee data to get it to work, so if we were to make an object like:

const deploymentOptions = {
    maxFeePerGas: gasFees['maxFeePerGas']
}

we would need to re update the object value every time we pull fresh data :/

Will need to think how to clean up that code

[baumstern]

• Also unify deploy functions too: https://github.com/privacy-scaling-explorations/maci//blob/v1/contracts/ts/deploy.ts#L120-L179

[ctrlc03]

• Also unify deploy functions too: https://github.com/privacy-scaling-explorations/maci//blob/v1/contracts/ts/deploy.ts#L120-L179

I think this can be unified in the cli. There might be reasons why one would only want to call one function at the time. Or maybe have a deployAll function as well that calls all of them

[baumstern]

Good shout, although I found that in between txs I had to pull fresh gas fee data to get it to work. Will need to think how to clean up that code

Had thought to solve it by something like following:

function invokeDeploy(contractFactory) {
    const gasFees = await signer.provider.getFeeData()

	return await contractFactory.deploy({
        maxFeePerGas: gasFees['maxFeePerGas'],
    })
}

[ctrlc03]

Good shout, although I found that in between txs I had to pull fresh gas fee data to get it to work. Will need to think how to clean up that code

Had thought to solve it by something like following:

function invokeDeploy(contractFactory) {
    const gasFees = await signer.provider.getFeeData()

	return await contractFactory.deploy({
        maxFeePerGas: gasFees['maxFeePerGas'],
    })
}

Nice this would definitely work

[baumstern]

• Also unify deploy functions too: https://github.com/privacy-scaling-explorations/maci//blob/v1/contracts/ts/deploy.ts#L120-L179

I think this can be unified in the cli. There might be reasons why one would only want to call one function at the time. Or maybe have a deployAll function as well that calls all of them

oh I intended to make just one function like following and call it from business logic:

function deployContract(name, args?) {
	const signer = await getDefaultSigner()
    const contractFactory = await ethers.getContractFactory('name', signer)
    const gasFees = await signer.provider.getFeeData()
    return await contractFactory.deploy({
        maxFeePerGas: gasFees['maxFeePerGas'],
    })
}

It would get rid of 50+ lines lol

[ctrlc03]

• Also unify deploy functions too: https://github.com/privacy-scaling-explorations/maci//blob/v1/contracts/ts/deploy.ts#L120-L179

I think this can be unified in the cli. There might be reasons why one would only want to call one function at the time. Or maybe have a deployAll function as well that calls all of them

oh I intended to make just one function like following and call it from business logic:

function deployContract(name, args?) {
	const signer = await getDefaultSigner()
    const contractFactory = await ethers.getContractFactory('name', signer)
    const gasFees = await signer.provider.getFeeData()
    return await contractFactory.deploy({
        maxFeePerGas: gasFees['maxFeePerGas'],
    })
}

It would get rid of 50+ lines lol

yea that's perfect will implement later

[ctrlc03]

We need to add the maxFeePerGas param to the deployment of pollFactory too, on my latest test deployment it failed while all others succeeded. Adding the following fixed it

{
        maxFeePerGas: gasFees['maxFeePerGas']
 }