Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(circuits): remove circomlib fork in favour of latest and zk-kit #1010

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat(circuits): remove circomlib fork in favour of latest and zk-kit #1010

merged 1 commit into from
Jan 15, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 12, 2024 •
edited
Loading

Description

Remove circomlib fork for poseidon decryption circuit, and use zk-kit instead. Also update circomlib to the latest version and use circomkit for circuits management and testing

Related issue(s)

fix #772

Confirmation

@ctrlc03 ctrlc03 self-assigned this Jan 12, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 12, 2024 •
edited
Loading

✅ Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit bf11b40
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65a43203b41876000899f173
😎 Deploy Preview https://deploy-preview-1010--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03 ctrlc03 added this to the MACI v1.1.1 refactor milestone Jan 12, 2024
@ctrlc03 ctrlc03 added dependencies Pull requests that update a dependency file testing Issue/PR related to tests circuits Related to the Circom circuits labels Jan 12, 2024
@ctrlc03 ctrlc03 force-pushed the feat/circuits-upgrades branch 8 times, most recently from 2894d06 to 6654ddd Compare January 12, 2024 18:57
0xmad
0xmad requested changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just few comments.
Regarding input types: I mentioned it only for one case by it's related to all the files in the PR.

circuits/circom/poseidon/poseidon.circom Show resolved Hide resolved
circuits/circom/poseidon/poseidon.circom Outdated Show resolved Hide resolved
circuits/circom/poseidon/poseidon.circom Show resolved Hide resolved
circuits/circom/test/processMessages_test.circom Outdated Show resolved Hide resolved
circuits/ts/__tests__/CeremonyParams.test.ts Outdated Show resolved Hide resolved
circuits/ts/__tests__/utils/utils.ts Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the feat/circuits-upgrades branch 2 times, most recently from 1249581 to a072554 Compare January 12, 2024 19:22
@ctrlc03 ctrlc03 force-pushed the feat/circuits-upgrades branch 4 times, most recently from ad1b2c4 to d701bb9 Compare January 12, 2024 19:43
@ctrlc03 ctrlc03 requested a review from 0xmad January 12, 2024 19:53
0xmad
0xmad approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@ctrlc03 ctrlc03 force-pushed the feat/circuits-upgrades branch 2 times, most recently from 8f9e0fa to 1d671bf Compare January 12, 2024 21:10
samajammin
samajammin reviewed Jan 13, 2024
View reviewed changes
circuits/package.json Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the feat/circuits-upgrades branch 14 times, most recently from f8060c4 to c2059b8 Compare January 14, 2024 15:04
@ctrlc03 ctrlc03 requested a review from samajammin January 14, 2024 15:09
kittybest
kittybest reviewed Jan 14, 2024
View reviewed changes
circuits/ts/__tests__/CalculateTotal.test.ts Outdated Show resolved Hide resolved
circuits/ts/__tests__/CalculateTotal.test.ts Outdated Show resolved Hide resolved
circuits/ts/__tests__/IncrementalQuinTree.test.ts Outdated Show resolved Hide resolved
circuits/ts/__tests__/MessageValidator.test.ts Outdated Show resolved Hide resolved
cli/testScript.sh Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the feat/circuits-upgrades branch from c2059b8 to 87c47df Compare January 14, 2024 16:59
@ctrlc03
feat(circuits): remove circomlib fork in favour of latest and zk-kit
bf11b40 
Remove circomlib fork for poseidon decryption circuit, and use zk-kit instead. Also update circomlib
to the latest version and use circomkit for circuits management and testing

fix #772
@ctrlc03 ctrlc03 force-pushed the feat/circuits-upgrades branch from 87c47df to bf11b40 Compare January 14, 2024 19:12
@ctrlc03 ctrlc03 requested a review from kittybest January 15, 2024 09:28
@ctrlc03 ctrlc03 mentioned this pull request Jan 15, 2024
Merged
3 tasks
@ctrlc03 ctrlc03 merged commit 2091bd2 into dev Jan 15, 2024
17 checks passed
@ctrlc03 ctrlc03 deleted the feat/circuits-upgrades branch January 15, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad approved these changes

@kittybest kittybest kittybest approved these changes

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

@samajammin samajammin Awaiting requested review from samajammin

Assignees

@ctrlc03 ctrlc03

Labels
circuits Related to the Circom circuits dependencies Pull requests that update a dependency file testing Issue/PR related to tests
Projects
MACI
Status: Done
Milestone
MACI v1.1.1 refactor
Development

Successfully merging this pull request may close these issues.

Poseidon encryption/decryption support
4 participants
@ctrlc03 @samajammin @kittybest @0xmad