refactor(optimisedmt): remove dependency and implement locally #1031

ctrlc03 · 2024-01-16T18:38:35Z

Description

Remove optimised dependency and implement locally
Add a dev package to run benchmarks.

Optimisedmt - Insert, Update and Gen and verify proof for 25 leaves:
    13.7 ops/s, ±2.79%   | slowest, 2.84% slower
MACI - gen and verify proof for 25 leaves:
    14.1 ops/s, ±1.28%   | fastest

run benchmarks
add workflow to run benchmarks on ci

Confirmation

I have read and understand MACI's contributor guidelines and code of conduct.
I have read and understand MACI's GitHub processes.
I have read and understand MACI's testing guide.

netlify · 2024-01-16T18:38:54Z

✅ Deploy Preview for maci-typedoc ready!

Name	Link
🔨 Latest commit	`c7d81e2`
🔍 Latest deploy log	https://app.netlify.com/sites/maci-typedoc/deploys/65a8209ea60435000876660c
😎 Deploy Preview	https://deploy-preview-1031--maci-typedoc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

0xmad

@ctrlc03 thanks, just left some comments

crypto/ts/quinTree.ts

crypto/ts/__tests__/IMT.test.ts

benchmarks/.gitignore

benchmarks/package.json

benchmarks/ts/src/optimisedmt.ts

package.json

crypto/ts/quinTree.ts

benchmarks/ts/suites/trees.ts

benchmarks/ts/suites/core.ts

benchmarks/ts/suites/trees.ts

benchmarks/ts/suites/constants.ts

benchmarks/ts/src/optimisedmt.ts

package.json

core/ts/__tests__/benchmarks/results/maci-core.chart.html

core/ts/__tests__/benchmarks/index.ts

core/ts/__tests__/benchmarks/results/maci-core.chart.html

.eslintignore

core/package.json

crypto/package.json

0xmad

@ctrlc03 thanks!

ctrlc03 · 2024-01-17T17:51:38Z

@ctrlc03 thanks!

thanks for the review!

crypto/ts/quinTree.ts

crypto/ts/__tests__/IMT.test.ts

crypto/ts/quinTree.ts

crypto/ts/__benchmarks__/suites/trees.ts

core/ts/__benchmarks__/index.ts

crypto/ts/__benchmarks__/suites/trees.ts

ctrlc03 self-assigned this Jan 16, 2024

ctrlc03 force-pushed the deps/optimisedmt branch from 6751b0d to fbca5ed Compare January 17, 2024 13:24

0xmad reviewed Jan 17, 2024

View reviewed changes

ctrlc03 force-pushed the deps/optimisedmt branch from fbca5ed to 7b911a9 Compare January 17, 2024 15:53

ctrlc03 marked this pull request as ready for review January 17, 2024 16:02

ctrlc03 requested review from kittybest, samajammin and crisgarner as code owners January 17, 2024 16:02

0xmad reviewed Jan 17, 2024

View reviewed changes

ctrlc03 force-pushed the deps/optimisedmt branch 2 times, most recently from 1676fe4 to 21368ab Compare January 17, 2024 16:48

0xmad reviewed Jan 17, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

ctrlc03 force-pushed the deps/optimisedmt branch 2 times, most recently from 9ee55bd to 198fef7 Compare January 17, 2024 17:24

0xmad reviewed Jan 17, 2024

View reviewed changes

ctrlc03 force-pushed the deps/optimisedmt branch from 198fef7 to 82e4b6e Compare January 17, 2024 17:38

ctrlc03 requested a review from 0xmad January 17, 2024 17:38

0xmad reviewed Jan 17, 2024

View reviewed changes

.eslintignore Outdated Show resolved Hide resolved

core/package.json Outdated Show resolved Hide resolved

crypto/package.json Outdated Show resolved Hide resolved

ctrlc03 force-pushed the deps/optimisedmt branch from 82e4b6e to d38affa Compare January 17, 2024 17:47

0xmad approved these changes Jan 17, 2024

View reviewed changes