Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): update ui-kit #1033

Merged
merged 7 commits into from
Jan 17, 2024
Merged

feat(website): update ui-kit #1033

merged 7 commits into from
Jan 17, 2024

Conversation

kittybest
Copy link
Collaborator

@kittybest kittybest commented Jan 17, 2024

Description

Mainly just update the ifm configs, to change

  1. colors
  2. font-family
  3. font-size
  4. some arrangement.

Related issue(s)

solve #871

Confirmation

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit df7616a
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65a840e581801200089750bc
😎 Deploy Preview https://deploy-preview-1033--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kittybest
Copy link
Collaborator Author

Setting it as draft now since I have some questions during building it, already asked the design team in dc channel.

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks, just few comments

website/src/pages/index.tsx Outdated Show resolved Hide resolved
website/src/css/custom.css Outdated Show resolved Hide resolved
website/src/components/HomepageFeatures/index.tsx Outdated Show resolved Hide resolved
website/docusaurus.config.ts Outdated Show resolved Hide resolved
@kittybest kittybest force-pushed the feat/ui-kit branch 4 times, most recently from 4c7fa88 to 525e01e Compare January 17, 2024 16:08
website/src/css/custom.css Outdated Show resolved Hide resolved
@samajammin
Copy link
Member

Nice @kittybest!

A few issues I see on light mode:
Image 2024-01-17 at 12 12 42

  • Nav links on hover turn white (so can't see text)
  • Header text colors are white (so can't see text)
  • Sidebar link for active route is white (so can't see text)
  • Breadcrumb link is white (so hard to see text) - should probably be black text like the version badge

@samajammin
Copy link
Member

Nice @kittybest!

A few issues I see on light mode:

  • Nav links on hover turn white (so can't see text)
  • Header text colors are white (so can't see text)
  • Sidebar link for active route is white (so can't see text)
  • Breadcrumb link is white (so hard to see text) - should probably be black text like the version badge

HAH, my bad, this was all caused by a change I made 😆

@samajammin samajammin marked this pull request as ready for review January 17, 2024 21:01
@samajammin samajammin merged commit 02aac21 into dev Jan 17, 2024
17 checks passed
@samajammin samajammin deleted the feat/ui-kit branch January 17, 2024 21:30
@0xmad 0xmad linked an issue Jan 17, 2024 that may be closed by this pull request
6 tasks
@samajammin samajammin mentioned this pull request Jan 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update website with brand kit
3 participants