Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): use object args for cli commands #1048

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 18, 2024

Description

Cleanup cli commands by using object args, as well as amend tests to reflect this change

Related issue(s)

fix #1035

Confirmation

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 41c4333
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65a962f3955408000814597c
😎 Deploy Preview https://deploy-preview-1048--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03 ctrlc03 force-pushed the refactor/cli-args branch 2 times, most recently from 4e7dd2b to 3eb84d4 Compare January 18, 2024 12:48
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just need to update the jsdoc for the functions and one question.

cli/tests/e2e/e2e.test.ts Outdated Show resolved Hide resolved
cli/ts/commands/airdrop.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ctrlc03 ctrlc03 force-pushed the refactor/cli-args branch 2 times, most recently from f36b8bb to dce4247 Compare January 18, 2024 17:41
cleanup cli commands by using object args, as well as amend tests to reflect this change
@ctrlc03 ctrlc03 requested a review from 0xmad January 18, 2024 17:44
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@0xmad 0xmad enabled auto-merge January 18, 2024 17:51
@0xmad 0xmad merged commit 7190205 into dev Jan 18, 2024
17 checks passed
@0xmad 0xmad deleted the refactor/cli-args branch January 18, 2024 17:55
kittybest pushed a commit that referenced this pull request Jan 18, 2024
…li-args

refactor(cli): use object args for cli commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

use interfaces for cli commands arguments
3 participants