New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eas-gatekeeper): implement an EAS gatekeeper for MACI #1109

Merged

ctrlc03 merged 1 commit into dev from feat/eas-gatekeeper

Jan 29, 2024

Collaborator

ctrlc03 commented Jan 26, 2024 •

edited

Loading

Description

Implement a MACI gatekeeper which allows signups only to users which have an attestation from a certain schema.

Additional Notes

The schema must be specified in the contract's constructor and it is immutable.

Related issue(s)

Confirmation

I have read and understand MACI's contributor guidelines and code of conduct.
I have read and understand MACI's GitHub processes.
I have read and understand MACI's testing guide.

ctrlc03 self-assigned this

ctrlc03 requested review from kittybest, 0xmad, samajammin and crisgarner as code owners

January 26, 2024 17:54

netlify bot commented Jan 26, 2024 •

edited

Loading

✅ Deploy Preview for maci-typedoc ready!

Name	Link
🔨 Latest commit	`8b25d94`
🔍 Latest deploy log	https://app.netlify.com/sites/maci-typedoc/deploys/65b7d7531ebc730008d5063d
😎 Deploy Preview	https://deploy-preview-1109--maci-typedoc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-advanced-security bot found potential problems

View reviewed changes

contracts/contracts/gatekeepers/EASGatekeeper.sol Dismissed Show dismissed Hide dismissed

contracts/contracts/gatekeepers/SignUpTokenGatekeeper.sol Dismissed Show dismissed Hide dismissed

contracts/contracts/gatekeepers/EASGatekeeper.sol Fixed Show resolved Hide resolved

contracts/contracts/gatekeepers/EASGatekeeper.sol Fixed Show fixed Hide fixed

contracts/contracts/gatekeepers/EASGatekeeper.sol Fixed Show fixed Hide fixed

contracts/contracts/gatekeepers/EASGatekeeper.sol Fixed Show fixed Hide fixed

contracts/contracts/gatekeepers/SignUpTokenGatekeeper.sol

@@ @@ -33,7 +33,7 @@ @@
                 /// @notice Adds an uninitialised MACI instance to allow for token signups
                 /// @param _maci The MACI contract interface to be stored
-                function setMaciInstance(MACI _maci) public override onlyOwner {
+                function setMaciInstance(address _maci) public override onlyOwner {

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter SignUpTokenGatekeeper.setMaciInstance(address)._maci is not in mixedCase

contracts/contracts/gatekeepers/EASGatekeeper.sol Fixed Show fixed Hide fixed

ctrlc03 force-pushed the feat/eas-gatekeeper branch 3 times, most recently from a6c86d4 to 5465cde Compare

January 26, 2024 18:14

samajammin reviewed

View reviewed changes

contracts/contracts/gatekeepers/EASGatekeeper.sol Outdated Show resolved Hide resolved

ctrlc03 force-pushed the feat/eas-gatekeeper branch from 5465cde to da346ec Compare

January 26, 2024 18:34

github-advanced-security bot found potential problems

View reviewed changes

contracts/contracts/gatekeepers/EASGatekeeper.sol Fixed Show resolved Hide resolved

ctrlc03 force-pushed the feat/eas-gatekeeper branch 2 times, most recently from 48989c0 to bf238bc Compare

January 26, 2024 18:56

github-advanced-security bot found potential problems

View reviewed changes

contracts/contracts/interfaces/IEAS.sol Fixed Show fixed Hide fixed

contracts/contracts/gatekeepers/EASGatekeeper.sol

		@@ -0,0 +1,85 @@
		// SPDX-License-Identifier: MIT
		pragma solidity ^0.8.10;

Check warning

Code scanning / Slither

Incorrect versions of Solidity Warning

Pragma version^0.8.10 allows old versions

0xmad requested changes

View reviewed changes

Collaborator

0xmad left a comment

@ctrlc03 thanks, just some comments

contracts/contracts/gatekeepers/EASGatekeeper.sol Fixed Show resolved Hide resolved

contracts/contracts/gatekeepers/EASGatekeeper.sol Fixed Show resolved Hide resolved

contracts/contracts/interfaces/IEAS.sol Outdated Show resolved Hide resolved

contracts/package.json Outdated Show resolved Hide resolved

.github/workflows/contracts-build.yml Show resolved Hide resolved

contracts/contracts/gatekeepers/SignUpTokenGatekeeper.sol Show resolved Hide resolved

ctrlc03 force-pushed the feat/eas-gatekeeper branch 2 times, most recently from 7a1b625 to 302f3c1 Compare

January 27, 2024 18:35

github-advanced-security bot found potential problems

View reviewed changes

contracts/contracts/gatekeepers/EASGatekeeper.sol

+                 * @param _user The user's Ethereum address.
+                 * @param _data The ABI-encoded schemaId as a uint256.
+                 */
+                function register(address _user, bytes memory _data) public override {

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter EASGatekeeper.register(address,bytes)._data is not in mixedCase

contracts/contracts/gatekeepers/EASGatekeeper.sol

+                /// @notice Adds an uninitialised MACI instance to allow for token signups
+                /// @param _maci The MACI contract interface to be stored
+                function setMaciInstance(address _maci) public override onlyOwner {

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter EASGatekeeper.setMaciInstance(address)._maci is not in mixedCase

contracts/contracts/gatekeepers/EASGatekeeper.sol

+                 * @param _user The user's Ethereum address.
+                 * @param _data The ABI-encoded schemaId as a uint256.
+                 */
+                function register(address _user, bytes memory _data) public override {

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter EASGatekeeper.register(address,bytes)._user is not in mixedCase

ctrlc03 force-pushed the feat/eas-gatekeeper branch from 302f3c1 to e430237 Compare

January 28, 2024 21:02

github-advanced-security bot found potential problems

View reviewed changes

contracts/contracts/interfaces/IEAS.sol

		@@ -0,0 +1,35 @@
		// SPDX-License-Identifier: MIT
		pragma solidity ^0.8.10;

Check warning

Code scanning / Slither

Incorrect versions of Solidity Warning

Pragma version^0.8.10 allows old versions

kittybest mentioned this pull request

Feat(contracts): EASSignupGateKeeper privacy-scaling-explorations/maci-platform#6

Closed

ctrlc03 force-pushed the feat/eas-gatekeeper branch from e430237 to e33dc60 Compare

January 29, 2024 15:25

kittybest reviewed

View reviewed changes

contracts/contracts/gatekeepers/EASGatekeeper.sol Show resolved Hide resolved

ctrlc03 force-pushed the feat/eas-gatekeeper branch from e33dc60 to dfeff26 Compare

January 29, 2024 15:30

kittybest approved these changes

View reviewed changes

ctrlc03 requested a review from 0xmad

January 29, 2024 15:55

ctrlc03 force-pushed the feat/eas-gatekeeper branch from dfeff26 to 2d3e25a Compare

January 29, 2024 15:55

kittybest reviewed

View reviewed changes

contracts/contracts/gatekeepers/EASGatekeeper.sol Show resolved Hide resolved

ctrlc03 force-pushed the feat/eas-gatekeeper branch from 2d3e25a to 91b74a7 Compare

January 29, 2024 16:11

0xmad approved these changes

View reviewed changes

Collaborator

0xmad left a comment

@ctrlc03 thanks, just one suggestion for tests.

contracts/tests/EASGatekeeper.test.ts Outdated Show resolved Hide resolved

ctrlc03 force-pushed the feat/eas-gatekeeper branch from 91b74a7 to b694dc5 Compare

January 29, 2024 16:29

ctrlc03 requested a review from samajammin

January 29, 2024 16:34


          feat(eas-gatekeeper): implement an eas gatekeeper for MACI

8b25d94

ctrlc03 force-pushed the feat/eas-gatekeeper branch from b694dc5 to 8b25d94 Compare

January 29, 2024 16:50

ctrlc03 enabled auto-merge

January 29, 2024 16:50

ctrlc03 merged commit 22a0e27 into dev

19 checks passed

ctrlc03 deleted the feat/eas-gatekeeper branch

January 29, 2024 17:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet