Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add get poll cli command #1224

Merged
merged 1 commit into from
Feb 20, 2024
Merged

feat(cli): add get poll cli command #1224

merged 1 commit into from
Feb 20, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Feb 20, 2024

Description

  • Add get poll cli command
  • Add indexed params for deploy poll event

Additional Notes

N/A

Related issue(s)

Related to privacy-scaling-explorations/maci-platform#10

Confirmation

@0xmad 0xmad added the enhancement New feature or request label Feb 20, 2024
@0xmad 0xmad self-assigned this Feb 20, 2024
Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit e6e2dd3
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65d52b338401310007c955a8
😎 Deploy Preview https://deploy-preview-1224--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0xmad 0xmad marked this pull request as ready for review February 20, 2024 22:23
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you! just two comments

cli/ts/commands/poll.ts Outdated Show resolved Hide resolved
cli/ts/commands/poll.ts Outdated Show resolved Hide resolved
@0xmad 0xmad requested a review from ctrlc03 February 20, 2024 22:38
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@0xmad 0xmad enabled auto-merge February 20, 2024 22:39
@0xmad 0xmad disabled auto-merge February 20, 2024 22:41
- [x] Add get poll cli command
- [x] Add indexed params for deploy poll event
@0xmad 0xmad merged commit d35c154 into dev Feb 20, 2024
19 checks passed
@0xmad 0xmad deleted the feature/cli-poll branch February 20, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants