fix: fix unable to publish package #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baumstern
requested review from
ctrlc03,
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctrlc03
approved these changes
Feb 27, 2024
kittybest
approved these changes
Feb 27, 2024
baumstern
force-pushed
the
fix/release
branch
from
27d4af4 to
4cc26ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent attempt to publish packages to npm failed and the root of the problem was our use of
lerna publish from-git, which is designed to publish packages tagged in the current commit. However, our CI process includes an additional commit after tagging (see here), meaning the current commit wasn't tagged at the time of publishing. This discrepancy led to Lerna's inability to publish using thefrom-gitmethod.To address the issue, this PR updates lerna to switch from
from-gittofrom-packagemethodAdditional Notes
Related issue(s)
Confirmation