fix: for genLocalState '-o' represents the path where to write the local state and not the pollId and must be be parsed as int. #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaetanoMondelli
requested review from
ctrlc03,
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kittybest
reviewed
Mar 18, 2024
ctrlc03
requested changes
Mar 19, 2024
GaetanoMondelli
force-pushed
the
fix-genLocalState-parse-option
branch
from
5f5b4b0 to
3326d4a
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 MACI Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the cli the command
genLocalStatehas ha '-o' parameter used to specifiy the path where to write the local state.Additional Notes
For other commands '-o' represented the pollId and the parameter required to be parsed into an integer but here trying to parse a path does nto allow to specify the path ending up to store the local store in a file called 'NaN'
Related issue(s)
--
Confirmation