chore: use non-zero start and end blocks for proof generation

[0xmad]

Description

• Update maci-contracts task
• Update maci-cli task
• Add indexed params for poll events
• Change deploy config example maci public key

Additional Notes

Now you don't need to specify start and end blocks. By default start block is a first signup event block; end - last merge aq event block.

Related issue(s)

MACI rpgf feedback discussion

Confirmation

• I have read and understand MACI's contributor guidelines and code of conduct.
• I have read and understand MACI's GitHub processes.
• I have read and understand MACI's testing guide.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
maci-website	✅ Ready (Inspect)	Visit Preview	Apr 1, 2024 7:21pm

[ctrlc03]

Great stuff, thank you

[ctrlc03]

@0xmad I think we missed something here, and surprised tests did not catch it. We should be counting the start block as the block where the MACI contract was deployed. This is because we add the first leaf to the state tree inside the constructor, so if we start fetching logs from either the first signup, or when the first poll is deployed, then we will have a mismatch here: https://github.com/privacy-scaling-explorations/maci/blob/dev/contracts/ts/genMaciState.ts#L362
will make a PR for it

[ctrlc03]

@0xmad I think we missed something here, and surprised tests did not catch it. We should be counting the start block as the block where the MACI contract was deployed. This is because we add the first leaf to the state tree inside the constructor, so if we start fetching logs from either the first signup, or when the first poll is deployed, then we will have a mismatch here: https://github.com/privacy-scaling-explorations/maci/blob/dev/contracts/ts/genMaciState.ts#L362 will make a PR for it

nope actually what I just said is not true haha it's fine to fetch from the first signup or first poll deployment because anyways we are not emitting an event for the first leaf and replicating the same logic off chain - my bad