Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(genlocalstate): add start block calculation on genLocalState cli command #1338

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Apr 2, 2024

Description

Introduce the new logic to determine first and last block for events fetching into the genLocalState command

Confirmation

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Apr 2, 2024 2:55pm

@ctrlc03 ctrlc03 self-assigned this Apr 2, 2024
@ctrlc03 ctrlc03 force-pushed the chore/gen-local-state-first-block branch from 8eaa74b to f4c4c26 Compare April 2, 2024 14:45
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just one refactoring suggestion

cli/ts/commands/genLocalState.ts Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the chore/gen-local-state-first-block branch from f4c4c26 to 615dee4 Compare April 2, 2024 14:53
@ctrlc03 ctrlc03 requested a review from 0xmad April 2, 2024 14:53
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@ctrlc03 ctrlc03 enabled auto-merge April 2, 2024 14:57
@ctrlc03 ctrlc03 merged commit cdff16a into dev Apr 2, 2024
19 checks passed
@ctrlc03 ctrlc03 deleted the chore/gen-local-state-first-block branch April 2, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants