chore: unify mention of maciAddress #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittybest
requested review from
ctrlc03,
0xmad,
samajammin and
crisgarner
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kittybest
force-pushed
the
chore/cli-cmd-name
branch
from
0223b37 to
dfc5fd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While running commands in cli, I found some of the commands using
--contract, some of them using--maci-contract-address, while rest of them using--maci-address, as input argument, which is hard to remember (though it's not necessary to add this parameter). Changing them all to--maci-address, update related arguments and interfaces.Tell me if the difference in names indicate something important, which shouldn't be changed.
Confirmation