Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contracts): tally qv and non-qv optimisations #1349

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat(contracts): tally qv and non-qv optimisations #1349

merged 1 commit into from
Apr 5, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Apr 4, 2024

Description

  • Remove TallyNonQv and TallyNonQvFactory
  • Add non-qv logic to Tally
  • Compatibility fixes

Confirmation

@0xmad 0xmad added the enhancement New feature or request label Apr 4, 2024
@0xmad 0xmad self-assigned this Apr 4, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Apr 5, 2024 1:45pm

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 4, 2024
View reviewed changes
contracts/contracts/TallyFactory.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/Tally.sol Fixed Show fixed Hide fixed
contracts/contracts/Tally.sol Fixed Show fixed Hide fixed
contracts/contracts/TallyFactory.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/Tally.sol Fixed Show fixed Hide fixed
contracts/contracts/Tally.sol Fixed Show fixed Hide fixed
contracts/contracts/Tally.sol Fixed Show fixed Hide fixed
contracts/contracts/MACI.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/Tally.sol Fixed Show fixed Hide fixed
contracts/contracts/SubsidyFactory.sol Fixed Show fixed Hide fixed
@0xmad 0xmad marked this pull request as ready for review April 4, 2024 22:03
ctrlc03
ctrlc03 requested changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, left a couple of comments

@0xmad
feat(contracts): tally qv and non-qv optimisations
b0b7b38 
- [x] Remove TallyNonQv and TallyNonQvFactory
- [x] Add non-qv logic to Tally
- [x] Compatibility fixes
@0xmad 0xmad force-pushed the feature/deploy-optimizations branch from 91190d6 to b0b7b38 Compare April 5, 2024 13:42
@0xmad 0xmad enabled auto-merge April 5, 2024 13:43
@0xmad 0xmad requested a review from ctrlc03 April 5, 2024 13:43
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 5, 2024
View reviewed changes
contracts/contracts/Tally.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/MACI.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/Tally.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/Tally.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/Tally.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/Tally.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/Tally.sol Dismissed Show dismissed Hide dismissed
ctrlc03
ctrlc03 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@0xmad 0xmad merged commit 037409c into dev Apr 5, 2024
19 checks passed
@0xmad 0xmad deleted the feature/deploy-optimizations branch April 5, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@kittybest kittybest Awaiting requested review from kittybest kittybest is a code owner

@samajammin samajammin Awaiting requested review from samajammin

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees

@0xmad 0xmad

Labels
enhancement New feature or request
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmad @ctrlc03