Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contract): support qv and non-qv verification keys #1354

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Apr 5, 2024

Description

  • Add mode for VkRegistry mappings
  • Compatibility fixes

Related issue(s)

Closes #1353

Confirmation

@0xmad 0xmad added the enhancement New feature or request label Apr 5, 2024
@0xmad 0xmad self-assigned this Apr 5, 2024
Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Apr 8, 2024 1:48pm

contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/MessageProcessorFactory.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
@0xmad 0xmad force-pushed the feature/vk-registry-multi-keys branch from a97f37e to 6f65ce0 Compare April 5, 2024 16:14
@0xmad 0xmad marked this pull request as ready for review April 5, 2024 16:27
- [x] Add mode for VkRegistry mappings
- [x] Compatibility fixes
@0xmad 0xmad force-pushed the feature/vk-registry-multi-keys branch from 6f65ce0 to a0cce8c Compare April 8, 2024 13:45
@0xmad 0xmad enabled auto-merge April 8, 2024 13:45
@0xmad 0xmad requested a review from ctrlc03 April 8, 2024 13:45
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@0xmad 0xmad merged commit dfb9b9d into dev Apr 8, 2024
19 checks passed
@0xmad 0xmad deleted the feature/vk-registry-multi-keys branch April 8, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Modularize VkRegistry to allow storing different versions of vkeys and different flavors
3 participants