Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add qv and non-qv key setup during deploy #1364

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Apr 9, 2024

Description

  • Update cli setVerificationKeys
  • Update maci-contracts deploy pipeline for VkRegistry

Additional Notes

N/A

Related issue(s)

Related #1355

Confirmation

@0xmad 0xmad added the chore Chore tasks label Apr 9, 2024
@0xmad 0xmad self-assigned this Apr 9, 2024
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Apr 10, 2024 2:36pm

contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/VkRegistry.sol Dismissed Show dismissed Hide dismissed
@0xmad 0xmad marked this pull request as ready for review April 9, 2024 21:01
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, left one comment

contracts/contracts/VkRegistry.sol Outdated Show resolved Hide resolved
- [x] Update cli setVerificationKeys
- [x] Update maci-contracts deploy pipeline for VkRegistry
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks

@0xmad 0xmad merged commit ca543fe into dev Apr 10, 2024
19 checks passed
@0xmad 0xmad deleted the chore/deploy-optimisations branch April 10, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants