Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support deployment without hardhat #1392

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Apr 24, 2024

Description

  • Use signer for deployment
  • Use hardhat as a fallback
  • Compatibility fixes

Additional Notes

N/A

Related issue(s)

Related to privacy-scaling-explorations/maci-platform#67

Confirmation

@0xmad 0xmad added the enhancement New feature or request label Apr 24, 2024
@0xmad 0xmad self-assigned this Apr 24, 2024
Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Apr 24, 2024 7:12pm

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

contracts/tasks/deploy/maci/02-gatekeepers.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works smoothly, thanks!

@0xmad 0xmad force-pushed the feature/deploy-maci-coordinator branch from 20e8065 to 9495bde Compare April 24, 2024 19:08
- [x] Use signer for deployment
- [x] Use hardhat as a fallback
- [x] Compatibility fixes
@0xmad 0xmad force-pushed the feature/deploy-maci-coordinator branch from 9495bde to dab5e2b Compare April 24, 2024 19:08
@0xmad 0xmad enabled auto-merge April 24, 2024 19:08
@0xmad 0xmad merged commit 02ad414 into dev Apr 24, 2024
20 checks passed
@0xmad 0xmad deleted the feature/deploy-maci-coordinator branch April 24, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants