fix: do not accept invalid maci keys #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlc03
requested review from
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ctrlc03
force-pushed
the
fix/validate-babyjubjub-point
branch
3 times, most recently
from
bc64906 to
3080a9a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
ctrlc03
force-pushed
the
fix/validate-babyjubjub-point
branch
from
3080a9a to
feb1eec
Compare
ctrlc03
force-pushed
the
fix/validate-babyjubjub-point
branch
from
feb1eec to
f625bb9
Compare
kittybest
reviewed
Apr 30, 2024
ctrlc03
force-pushed
the
fix/validate-babyjubjub-point
branch
from
f625bb9 to
f5174d0
Compare
0xmad
approved these changes
Apr 30, 2024
ctrlc03
force-pushed
the
fix/validate-babyjubjub-point
branch
from
f5174d0 to
8dd41bb
Compare
ctrlc03
force-pushed
the
fix/validate-babyjubjub-point
branch
from
8dd41bb to
b815998
Compare
ctrlc03
force-pushed
the
fix/validate-babyjubjub-point
branch
from
b815998 to
4be3a28
Compare
ctrlc03
force-pushed
the
fix/validate-babyjubjub-point
branch
from
4be3a28 to
9f9e858
Compare
crisgarner
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure MACI keys are correctly validated to be a point on the babyjujub curve
Confirmation