refactor(topup): remove the topup feature #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlc03
requested review from
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ctrlc03
force-pushed
the
refactor/remove-topup
branch
from
3015dd9 to
6b89d9a
Compare
ctrlc03
force-pushed
the
refactor/remove-topup
branch
from
6b89d9a to
3bcbb6e
Compare
0xmad
approved these changes
May 3, 2024
ctrlc03
force-pushed
the
refactor/remove-topup
branch
from
3bcbb6e to
d3cab94
Compare
ctrlc03
force-pushed
the
refactor/remove-topup
branch
from
d3cab94 to
b300ae7
Compare
ctrlc03
force-pushed
the
refactor/remove-topup
branch
from
b300ae7 to
480772c
Compare
ctrlc03
force-pushed
the
refactor/remove-topup
branch
from
480772c to
f44c89d
Compare
ctrlc03
force-pushed
the
refactor/remove-topup
branch
from
f44c89d to
5a9a093
Compare
ctrlc03
force-pushed
the
refactor/remove-topup
branch
from
5a9a093 to
fa9da09
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -30,8 +26,7 @@ | |||
| MaxValues calldata _maxValues, | |||
| TreeDepths calldata _treeDepths, | |||
| PubKey calldata _coordinatorPubKey, | |||
| address _maci, | |||
| TopupCredit _topupCredit | |||
| address _maci | |||
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
remove the topup feature until a more appropriate design is proposed. Currently the feature is not used in production and adds unnecessary complexity to the code. A re-design is necessary to make it an effective feature. BREAKING CHANGE: No more topups
ctrlc03
force-pushed
the
refactor/remove-topup
branch
from
fa9da09 to
67711d4
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove the topup feature until a more appropriate design is proposed. Currently the feature is not used in production and adds unnecessary complexity to the code. A re-design is necessary to make it an effective feature.
BREAKING CHANGE: No more topups
Related issue(s)
re #1384
Confirmation