feat: add signer as input for deployContractWithLinkedLibraries #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittybest
requested review from
ctrlc03,
0xmad,
samajammin and
crisgarner
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kittybest
force-pushed
the
chore/deployment-update
branch
from
2e5b3c6 to
b6cd592
Compare
0xmad
requested changes
May 9, 2024
There was a problem hiding this comment.
@kittybest thanks, just one comment and change commit to feat.
kittybest
force-pushed
the
chore/deployment-update
branch
from
b6cd592 to
53b5487
Compare
kittybest
changed the title
crisgarner
approved these changes
May 9, 2024
0xmad
reviewed
May 9, 2024
kittybest
force-pushed
the
chore/deployment-update
branch
from
53b5487 to
5a7c424
Compare
kittybest
force-pushed
the
chore/deployment-update
branch
from
5a7c424 to
7fbe965
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if using
Deploymenthelper to deploy contracts with linked libraries, it would check if there is hardhat environment running or not. Make this optional by acceptingsigneras input argument, for frontend to call and use.Confirmation