Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup): remove references to topup #1489

Merged
merged 1 commit into from
May 22, 2024
Merged

chore(cleanup): remove references to topup #1489

merged 1 commit into from
May 22, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented May 22, 2024

Description

Remove topup references

Confirmation

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview May 22, 2024 3:04pm

@ctrlc03 ctrlc03 self-assigned this May 22, 2024
@ctrlc03 ctrlc03 added the chore Chore tasks label May 22, 2024
@ctrlc03 ctrlc03 enabled auto-merge May 22, 2024 09:22
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR also take care of the documentation part?


The MACI contract is the core of the protocol. Contracts can inherit from MACI and thus expose the signup and topup functions. As with standalone MACI, one would need to deploy a [sign up gatekeeper](/docs/developers-references/smart-contracts/Gatekeepers) as well as the [voice credit proxy](/docs/developers-references/smart-contracts/VoiceCreditProxy).


⬆️ There is still topup mentioned here.

Also the pictures used to explain the message processing should be modified.

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented May 22, 2024

Is this PR also take care of the documentation part?

The MACI contract is the core of the protocol. Contracts can inherit from MACI and thus expose the signup and topup functions. As with standalone MACI, one would need to deploy a [sign up gatekeeper](/docs/developers-references/smart-contracts/Gatekeepers) as well as the [voice credit proxy](/docs/developers-references/smart-contracts/VoiceCreditProxy).

⬆️ There is still topup mentioned here.
Also the pictures used to explain the message processing should be modified.

first one is fixed in the deployment docs PR, second one too and the third I'm planning to have a separate PR for circuits to organize those docs and update all in one

@ctrlc03 ctrlc03 requested a review from kittybest May 22, 2024 14:24
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, if docs are updated in next PR, it works!

@ctrlc03 ctrlc03 merged commit 8f8d6fd into dev May 22, 2024
21 checks passed
@ctrlc03 ctrlc03 deleted the chore/cleanup branch May 22, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants