-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cleanup): remove references to topup #1489
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR also take care of the documentation part?
7. Deploy Topup credit |
maci/website/versioned_docs/version-v2.0_alpha/developers-references/integrating.md
Line 197 in 5479617
The MACI contract is the core of the protocol. Contracts can inherit from MACI and thus expose the signup and topup functions. As with standalone MACI, one would need to deploy a [sign up gatekeeper](/docs/developers-references/smart-contracts/Gatekeepers) as well as the [voice credit proxy](/docs/developers-references/smart-contracts/VoiceCreditProxy). |
maci/website/versioned_docs/version-v2.0_alpha/developers-references/zk-snark-circuits/circuits.md
Line 403 in 5479617
#### ProcessTopup |
⬆️ There is still topup mentioned here.
Also the pictures used to explain the message processing should be modified.
first one is fixed in the deployment docs PR, second one too and the third I'm planning to have a separate PR for circuits to organize those docs and update all in one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrlc03 thanks, if docs are updated in next PR, it works!
Description
Remove topup references
Confirmation