Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: coordinator public key method #1507

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented May 23, 2024

Description

  • Add api method for getting rsa public key
  • Use dependency injection for crypto service
  • Move file related logic to a separate service
  • Add explicit public by-pass for authorization

Additional Notes

N/A

Related issue(s)

Closes privacy-scaling-explorations/maci-platform#58

Confirmation

@0xmad 0xmad added the enhancement New feature or request label May 23, 2024
@0xmad 0xmad self-assigned this May 23, 2024
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview May 24, 2024 1:01pm

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some comments

coordinator/ts/file/file.service.ts Show resolved Hide resolved
coordinator/ts/file/file.service.ts Outdated Show resolved Hide resolved
@0xmad 0xmad force-pushed the feature/coordinator-public-key branch from f66f81f to 217a91e Compare May 24, 2024 12:56
- [x] Add api method for getting rsa public key
- [x] Use dependency injection for crypto service
- [x] Move file related logic to a separate service
- [x] Add explicit public by-pass for authorization
@0xmad 0xmad force-pushed the feature/coordinator-public-key branch from 217a91e to 36dbd4f Compare May 24, 2024 12:57
@0xmad 0xmad enabled auto-merge May 24, 2024 13:02
@0xmad 0xmad requested a review from ctrlc03 May 24, 2024 14:06
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xmad 0xmad merged commit d0b5add into dev May 24, 2024
21 checks passed
@0xmad 0xmad deleted the feature/coordinator-public-key branch May 24, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Deploy coordinator service
2 participants