Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deploy-task): added zupass gatekeeper to the deploy tasks #1531

Merged
merged 4 commits into from
Jun 5, 2024
Merged

feat(deploy-task): added zupass gatekeeper to the deploy tasks #1531

merged 4 commits into from
Jun 5, 2024

Conversation

crisgarner
Copy link
Collaborator

@crisgarner crisgarner commented Jun 5, 2024 •
edited
Loading

Description

Added zupass gatekeeper to the deploy tasks and deploy config example

@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jun 5, 2024 5:57pm

ctrlc03
ctrlc03 requested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some comments

contracts/package.json Outdated Show resolved Hide resolved
contracts/tasks/deploy/maci/02-gatekeepers.ts Outdated Show resolved Hide resolved
contracts/tasks/deploy/maci/08-maci.ts Outdated Show resolved Hide resolved
@crisgarner
Copy link
Collaborator Author

Thanks! implemented the recommendations

0xmad
0xmad requested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crisgarner thanks, left some comments

contracts/tasks/deploy/maci/02-gatekeepers.ts Outdated Show resolved Hide resolved
contracts/tasks/deploy/maci/02-gatekeepers.ts Outdated Show resolved Hide resolved
contracts/tasks/deploy/maci/02-gatekeepers.ts Outdated Show resolved Hide resolved
contracts/tasks/deploy/maci/02-gatekeepers.ts Outdated Show resolved Hide resolved
contracts/tasks/helpers/NumericRepresentation.ts Outdated Show resolved Hide resolved
contracts/tasks/helpers/NumericRepresentation.ts Outdated Show resolved Hide resolved
contracts/tasks/helpers/NumericRepresentation.ts Outdated Show resolved Hide resolved
@crisgarner
Copy link
Collaborator Author

Thanks! added the recommendations @0xmad

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Jun 5, 2024 •
edited
Loading

Thanks! added the recommendations @0xmad

seems like the project is not building @crisgarner

kittybest
kittybest approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just need to check the import path / file nam.

0xmad
0xmad approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crisgarner thanks!

@crisgarner crisgarner merged commit f0b482d into dev Jun 5, 2024
21 checks passed
@crisgarner crisgarner deleted the feat/zupass-gatekeeper-deployer branch June 5, 2024 19:49
@crisgarner crisgarner mentioned this pull request Jun 6, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@0xmad 0xmad 0xmad approved these changes

@kittybest kittybest kittybest approved these changes

@samajammin samajammin Awaiting requested review from samajammin

Assignees

@crisgarner crisgarner

Labels
None yet
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisgarner @ctrlc03 @kittybest @0xmad