Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export typechain instead of contract #1590

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

kittybest
Copy link
Collaborator

@kittybest kittybest commented Jun 21, 2024

Description

Since the mergeSignups and mergeMessages import MACIFactory from maci-contracts, so the frontend would accidentally import hardhat packages, which caused the frontend error.

image

Related issue(s)

privacy-scaling-explorations/maci-platform#167

Confirmation

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jun 21, 2024 5:09pm

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks!

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kittybest kittybest force-pushed the fix/export-contract-type branch from 5ec074f to 78ce09b Compare June 21, 2024 17:04
@ctrlc03 ctrlc03 force-pushed the fix/export-contract-type branch from 78ce09b to 20db4f6 Compare June 21, 2024 17:06
@kittybest kittybest force-pushed the fix/export-contract-type branch from 20db4f6 to 4aa6cab Compare June 21, 2024 17:06
@ctrlc03 ctrlc03 enabled auto-merge (squash) June 21, 2024 17:06
@ctrlc03 ctrlc03 merged commit 4e792c4 into dev Jun 21, 2024
22 checks passed
@ctrlc03 ctrlc03 deleted the fix/export-contract-type branch June 21, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants