-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts): add first registry and payout extensions #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ctrlc03
force-pushed
the
feat/registry-payout-extensions
branch
from
July 5, 2024 19:53
ecc89be
to
b2e5daa
Compare
ctrlc03
force-pushed
the
feat/registry-payout-extensions
branch
from
July 5, 2024 19:59
b2e5daa
to
f8357bc
Compare
ctrlc03
force-pushed
the
feat/registry-payout-extensions
branch
from
July 5, 2024 20:05
f8357bc
to
19cea25
Compare
ctrlc03
force-pushed
the
feat/registry-payout-extensions
branch
from
July 8, 2024 07:13
19cea25
to
2c089e8
Compare
ctrlc03
force-pushed
the
feat/registry-payout-extensions
branch
from
July 8, 2024 10:22
2c089e8
to
7c4926d
Compare
ctrlc03
force-pushed
the
feat/registry-payout-extensions
branch
from
July 8, 2024 10:45
7c4926d
to
66e0f3c
Compare
ctrlc03
force-pushed
the
feat/registry-payout-extensions
branch
from
July 8, 2024 10:50
66e0f3c
to
3af663b
Compare
ctrlc03
force-pushed
the
feat/registry-payout-extensions
branch
from
July 10, 2024 14:49
3af663b
to
26836f6
Compare
5 tasks
0xmad
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrlc03 thanks, just left some comments
0xmad
force-pushed
the
feat/registry-payout-extensions
branch
from
August 8, 2024 19:23
26836f6
to
53e53af
Compare
packages/contracts/contracts/extensions/registry/SimpleRecipientRegistry.sol
Fixed
Show fixed
Hide fixed
packages/contracts/contracts/extensions/registry/SimpleRecipientRegistry.sol
Fixed
Show fixed
Hide fixed
0xmad
approved these changes
Aug 8, 2024
0xmad
force-pushed
the
feat/registry-payout-extensions
branch
from
August 8, 2024 20:43
53e53af
to
d1345f2
Compare
packages/contracts/contracts/extensions/registry/SimpleRecipientRegistry.sol
Dismissed
Show dismissed
Hide dismissed
packages/contracts/contracts/extensions/registry/SimpleRecipientRegistry.sol
Dismissed
Show dismissed
Hide dismissed
0xmad
force-pushed
the
feat/registry-payout-extensions
branch
from
August 8, 2024 21:02
d1345f2
to
d75164b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an extensions folder inside contracts and add a simple implementation of a registry and a payout contract.
Additional Info
Can merge after v2.0 release
Related Issues
fix #1634
fix #1633
Confirmation