Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): add first registry and payout extensions #1631

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jul 5, 2024

Description

Add an extensions folder inside contracts and add a simple implementation of a registry and a payout contract.

Additional Info

Can merge after v2.0 release

Related Issues

fix #1634
fix #1633

Confirmation

Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Aug 9, 2024 2:33pm

@ctrlc03 ctrlc03 force-pushed the feat/registry-payout-extensions branch from ecc89be to b2e5daa Compare July 5, 2024 19:53
@ctrlc03 ctrlc03 force-pushed the feat/registry-payout-extensions branch from b2e5daa to f8357bc Compare July 5, 2024 19:59
contracts/contracts/mocks/MockWETH.sol Fixed Show fixed Hide fixed
contracts/contracts/mocks/MockWETH.sol Fixed Show fixed Hide fixed
contracts/contracts/mocks/MockWETH.sol Fixed Show fixed Hide fixed
@ctrlc03 ctrlc03 force-pushed the feat/registry-payout-extensions branch from 19cea25 to 2c089e8 Compare July 8, 2024 07:13
@ctrlc03 ctrlc03 force-pushed the feat/registry-payout-extensions branch from 2c089e8 to 7c4926d Compare July 8, 2024 10:22
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just left some comments

contracts/contracts/extensions/payout/SimplePayout.sol Outdated Show resolved Hide resolved
contracts/contracts/extensions/payout/SimplePayout.sol Outdated Show resolved Hide resolved
contracts/contracts/extensions/payout/SimplePayout.sol Fixed Show resolved Hide resolved
contracts/contracts/gatekeepers/SignUpTokenGatekeeper.sol Outdated Show resolved Hide resolved
contracts/contracts/mocks/MockWETH.sol Outdated Show resolved Hide resolved
contracts/tests/extensions/SimplePayout.test.ts Outdated Show resolved Hide resolved
contracts/tests/extensions/SimpleProjectRegistry.test.ts Outdated Show resolved Hide resolved
@0xmad 0xmad force-pushed the feat/registry-payout-extensions branch from 26836f6 to 53e53af Compare August 8, 2024 19:23
@0xmad 0xmad enabled auto-merge August 9, 2024 14:31
@0xmad 0xmad merged commit ba62b2e into dev Aug 9, 2024
22 checks passed
@0xmad 0xmad deleted the feat/registry-payout-extensions branch August 9, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement a simple payout contract Implement a simple project registry
2 participants