Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coordinator): add websockets support #1638

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Jul 9, 2024

Description

  • Add websockets gateway for proof generation
  • Update AccountSignatureGuard to work with websockets
  • Add hooks for proof generation: progress, finish, error

Additional Notes

N/A

Related issue(s)

Closes #1616

Confirmation

@0xmad 0xmad added the enhancement New feature or request label Jul 9, 2024
@0xmad 0xmad self-assigned this Jul 9, 2024
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jul 10, 2024 10:13am

@0xmad 0xmad force-pushed the feature/coordinator-websockets branch 2 times, most recently from 1a0101c to 6394774 Compare July 9, 2024 21:44
@0xmad 0xmad force-pushed the feature/coordinator-websockets branch from 6394774 to cbe02ac Compare July 9, 2024 21:46
- [x] Add websockets gateway for proof generation
- [x] Update AccountSignatureGuard to work with websockets
- [x] Add hooks for proof generation: progress, finish, error
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, but I cannot successfully run the tests and the server, need to figure this part out QQ

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Jul 10, 2024

code looks good to me, but I cannot successfully run the tests and the server, need to figure this part out QQ

did you run pnpm hardhat & inside the coordinator folder first? wasn't working for me then run that and all tests pass

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks

@0xmad 0xmad merged commit 4cb0d36 into dev Jul 10, 2024
22 checks passed
@0xmad 0xmad deleted the feature/coordinator-websockets branch July 10, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support websockets for coordinator service
3 participants