Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(coordinator): deploy subgraph from coordinator service #1643

Merged
merged 1 commit into from
Jul 15, 2024
Merged

feat(coordinator): deploy subgraph from coordinator service #1643

merged 1 commit into from
Jul 15, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Jul 12, 2024

Description

  • Add subgraph controller
  • Add subgraph deploy service
  • Remove app controller and use proof controller
  • Add env variables

Additional Notes

N/A

Related issue(s)

Related #1629

Confirmation

@0xmad 0xmad added the enhancement New feature or request label Jul 12, 2024
@0xmad 0xmad self-assigned this Jul 12, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jul 15, 2024 3:43pm

@0xmad 0xmad force-pushed the feature/deploy-subgraph branch from bd4b105 to bc8706c Compare July 12, 2024 17:19
@0xmad 0xmad force-pushed the feature/deploy-subgraph branch from bc8706c to 3d16afd Compare July 12, 2024 17:32
@0xmad 0xmad force-pushed the feature/deploy-subgraph branch from 3d16afd to acb93d6 Compare July 12, 2024 17:54
ctrlc03
ctrlc03 reviewed Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just left one question

coordinator/ts/subgraph/__tests__/subgraph.controller.test.ts Outdated Show resolved Hide resolved
coordinator/ts/subgraph/types.ts Show resolved Hide resolved
@ctrlc03 ctrlc03 self-requested a review July 15, 2024 14:59
ctrlc03
ctrlc03 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@0xmad 0xmad force-pushed the feature/deploy-subgraph branch from acb93d6 to 9de7b67 Compare July 15, 2024 15:00
@0xmad 0xmad enabled auto-merge July 15, 2024 15:01
@0xmad 0xmad force-pushed the feature/deploy-subgraph branch from 9de7b67 to 126cfba Compare July 15, 2024 15:10
@ctrlc03 ctrlc03 force-pushed the feature/deploy-subgraph branch from 126cfba to f02148e Compare July 15, 2024 15:16
@0xmad @ctrlc03
feat(coordinator): deploy subgraph from coordinator service
d04d82c 
- [x] Add subgraph controller
- [x] Add subgraph deploy service
- [x] Remove app controller and use proof controller
- [x] Add env variables
@ctrlc03 ctrlc03 force-pushed the feature/deploy-subgraph branch from f02148e to d04d82c Compare July 15, 2024 15:36
@0xmad 0xmad merged commit d182f79 into dev Jul 15, 2024
22 checks passed
@0xmad 0xmad deleted the feature/deploy-subgraph branch July 15, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@kittybest kittybest Awaiting requested review from kittybest kittybest is a code owner

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees

@0xmad 0xmad

Labels
enhancement New feature or request
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmad @ctrlc03