Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): allow for dynamic emptyBallotRoots #1695

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jul 23, 2024

Description

Pass emptyBallotRoots as argument to the maci contract and then the specific ballot root to each deployed poll based on the vote option tree depth. This simplifies the process and does not require setting a .env variable before deploying contracts.

Additional Notes

Confirmation

@ctrlc03 ctrlc03 self-assigned this Jul 23, 2024
Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jul 23, 2024 5:29pm

contracts/contracts/PollFactory.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/PollFactory.sol Dismissed Show dismissed Hide dismissed
Pass emptyBallotRoots as argument to the maci contract and then the specific ballot root to each
deployed poll based on the vote option tree depth. This simplifies the process and does not require
setting a .env variable before deploying contracts.
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@ctrlc03 ctrlc03 merged commit e7aa4dd into dev Jul 25, 2024
22 checks passed
@ctrlc03 ctrlc03 deleted the feat/dynamic-empty-ballot-roots branch July 25, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants