Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(contracts): do not return contract addresses on poll deploy #1727

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Aug 5, 2024

Description

Do not return poll/mp/tally addresses as they are already saved to state

Related issue(s)

fix #1724

Confirmation

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Aug 5, 2024 4:01pm

@ctrlc03 ctrlc03 self-assigned this Aug 5, 2024
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from ad5496d to 6b3fcd6 Compare August 5, 2024 12:28
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from 6b3fcd6 to c3cfba9 Compare August 5, 2024 12:41
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from c3cfba9 to 1cb77b6 Compare August 5, 2024 12:46
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from 1cb77b6 to ab96ffa Compare August 5, 2024 12:51
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from ab96ffa to d710525 Compare August 5, 2024 12:55
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from d710525 to ad62975 Compare August 5, 2024 13:01
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from ad62975 to 2b724f2 Compare August 5, 2024 13:04
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from 2b724f2 to 0fb0936 Compare August 5, 2024 13:09
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from 0fb0936 to 7bde85a Compare August 5, 2024 13:15
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from 7bde85a to 16db527 Compare August 5, 2024 13:19
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from 16db527 to 4bc48ec Compare August 5, 2024 13:22
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from 4bc48ec to 0b58f34 Compare August 5, 2024 13:29
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch 2 times, most recently from da63ba3 to d768365 Compare August 5, 2024 14:25
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from d768365 to d3ae693 Compare August 5, 2024 14:56
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just some comments

contracts/ts/genMaciState.ts Show resolved Hide resolved
subgraph/tests/common.ts Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the refactor/poll-addr branch from 227f368 to 43d5224 Compare August 5, 2024 15:59
@0xmad 0xmad enabled auto-merge August 5, 2024 20:20
@0xmad 0xmad merged commit c7b2b56 into dev Aug 5, 2024
22 checks passed
@0xmad 0xmad deleted the refactor/poll-addr branch August 5, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Maci.deployPoll no need to return PollAddr as they are stored and do not emit on event
3 participants