-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(contracts): do not return contract addresses on poll deploy #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 12:28
ad5496d
to
6b3fcd6
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 12:41
6b3fcd6
to
c3cfba9
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 12:46
c3cfba9
to
1cb77b6
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 12:51
1cb77b6
to
ab96ffa
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 12:55
ab96ffa
to
d710525
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 13:01
d710525
to
ad62975
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 13:04
ad62975
to
2b724f2
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 13:09
2b724f2
to
0fb0936
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 13:15
0fb0936
to
7bde85a
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 13:19
7bde85a
to
16db527
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 13:22
16db527
to
4bc48ec
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 13:29
4bc48ec
to
0b58f34
Compare
kittybest
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ctrlc03
force-pushed
the
refactor/poll-addr
branch
2 times, most recently
from
August 5, 2024 14:25
da63ba3
to
d768365
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 14:56
d768365
to
d3ae693
Compare
0xmad
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrlc03 thanks, just some comments
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 15:41
d3ae693
to
dc6d290
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 15:48
dc6d290
to
227f368
Compare
ctrlc03
force-pushed
the
refactor/poll-addr
branch
from
August 5, 2024 15:59
227f368
to
43d5224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not return poll/mp/tally addresses as they are already saved to state
Related issue(s)
fix #1724
Confirmation