Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update trusted setup docs and fix links #1806

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Sep 2, 2024

Description

Update trusted setup docs and links

Related issue(s)

fix #1717

Confirmation

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Sep 4, 2024 4:31pm

Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! just left some comments.

apps/website/blog/2024-02-28-maci-v1.2.0.md Outdated Show resolved Hide resolved
apps/website/blog/2024-05-08-ethdam.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For practical implementation insights, review our docs as well as the [clr.fund](https://github.com/clrfund/monorepo/) and [QF](https://github.com/privacy-scaling-explorations/qf) repositories as reference implementations. Both are quadratic funding implementations, a mechanism which otherwise is highly susceptible to collusion and bribery. Most notably, clr.fund is already working on integrating MACI v1.2.0, after having used v0.x until now. You can follow their development effort under this [GitHub branch](https://github.com/clrfund/monorepo/tree/feat/maci-v1).

This link (https://github.com/clrfund/monorepo/tree/feat/maci-v1) and this link (https://github.com/privacy-scaling-explorations/qf) are no longer available.

@kittybest
Copy link
Collaborator

When passed to the circuit, the code would perform the ECDH operation by performing a scalar multiplication between the public and the coordinator private key. This happens inside the [`MessageToCommand`](https://github.com/privacy-scaling-explorations/maci/blob/v1.2.0/circuits/circom/messageToCommand.circom#L41) template, which calls the [`ECDH` template](https://github.com/privacy-scaling-explorations/zk-kit/blob/main/packages/circuits/circom/ecdh.circom). Here, there is a call to [`escalarMulAny`](https://github.com/privacy-scaling-explorations/zk-kit/blob/main/packages/circuits/circom/ecdh.circom#L26) which in turns calls [`SegmentMulAny`](https://github.com/iden3/circomlib/blob/master/circuits/escalarmulany.circom#L154), where we encounter the final call to [`Edwards2Montgomery`](https://github.com/iden3/circomlib/blob/master/circuits/escalarmulany.circom#L78) where the error pops up.

This link (https://github.com/privacy-scaling-explorations/zk-kit/blob/main/packages/circuits/circom/ecdh.circom), and this link (https://github.com/privacy-scaling-explorations/zk-kit/blob/main/packages/circuits/circom/ecdh.circom#L26) are no longer available.

@ctrlc03 ctrlc03 requested a review from kittybest September 4, 2024 16:29
@ctrlc03 ctrlc03 requested a review from kittybest September 4, 2024 18:16
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ctrlc03 ctrlc03 merged commit 3154f1a into dev Sep 5, 2024
22 checks passed
@ctrlc03 ctrlc03 deleted the docs/trusted-setup-and-links branch September 5, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update docs for v2 release with trusted setup details and compatibility
2 participants