-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Redesigned projects built with MACI page #1813
refactor: Redesigned projects built with MACI page #1813
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @ctrlc03, sorry for the delay. Please let me know if any adjustments are needed regarding themes, wording, conventions, etc. |
637990f
to
1979dfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing thank you very much 🚀
Could you please ensure linter checks are passed (you can run locally with pnpm lint:ts:fix
) and also it seems like navigation buttons are not displaying correctly in light mode, and the cards and text also
1979dfa
to
eca0fef
Compare
Thank you @ctrlc03 @kittybest! Please let me know if any other changes are needed. Projects.built.with.MACI._.MACI.-.Google.Chrome.2024-09-09.22-06-02.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks so much!! @kittybest I'll leave the final approval to you before merging in case you had more suggestions.
Only one thing please rebase to dev and squash your commits into one
git reset $(git merge-base dev $(git rev-parse --abbrev-ref HEAD))
a36c495
to
4c6a540
Compare
c5bd6a3
to
b05bab1
Compare
6c938d2
to
df78413
Compare
@MukulKolpe seems like you used merge rather than rebase, please squash your commits and rebase to the latest dev :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks so nice, thanks a lot!
dae2b00
to
0868cf4
Compare
32acd31
to
49deb07
Compare
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 MACI Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Description
Redesigned the MACI projects page to improve user interface and make it easier to update when new projects are added.
Minimal.Anti-Collusion.Infrastructure.MACI._.MACI.-.Google.Chrome.2024-09-06.15-16-54.mp4
Additional Notes
Related issue(s)
Fixes #1613
Confirmation