Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): add total spent to tally #1866

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat(contracts): add total spent to tally #1866

merged 1 commit into from
Oct 22, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Oct 21, 2024

Description

  • Update add tally results method signature
  • Compatibility fixes
  • Add total spent to tally contract

Additional Notes

Need for alpha calculation in privacy-scaling-explorations/maci-platform#353

Related issue(s)

Related to privacy-scaling-explorations/maci-platform#263

Confirmation

@0xmad 0xmad added the enhancement New feature or request label Oct 21, 2024
@0xmad 0xmad self-assigned this Oct 21, 2024
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Oct 22, 2024 6:13pm

packages/contracts/contracts/Tally.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/Tally.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/Tally.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/Tally.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/Tally.sol Dismissed Show dismissed Hide dismissed
@0xmad 0xmad enabled auto-merge October 21, 2024 18:13
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

- [x] Update add tally results method signature
- [x] Compatibility fixes
- [x] Add total spent to tally contract
@kittybest kittybest force-pushed the feature/tally-results branch from d0a015f to ac206f3 Compare October 22, 2024 18:10
@0xmad 0xmad merged commit ef22687 into dev Oct 22, 2024
22 checks passed
@0xmad 0xmad deleted the feature/tally-results branch October 22, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants