test(contracts): check the NOTHING_UP_MY_SLEEVE value in Poll test suite #1972
Conversation
wildanvin
requested review from
ctrlc03,
kittybest,
0xmad and
crisgarner
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@wildanvin thanks for opening this PR. Right so the idea is that inside the smart contracts, we always init the message tree (or hash chain now) with this NOTHING_UP_MY_SLEEVE value (https://github.com/privacy-scaling-explorations/maci/blob/dev/packages/contracts/contracts/Poll.sol#L201) - However I'm giving it some more thought atm and think this issue could even just be closed as all e2e/integration tests do include that value, it would only be some unit tests |
| expect( | ||
| NOTHING_UP_MY_SLEEVE === BigInt("8370432830353022751713833565135785980866757267633941821328460903436894336785"), | ||
| ); |
There was a problem hiding this comment.
I'm not sure if I makes sense to check the constant value in tests.
I think the idea is to check this value is inside the tree. Checking the constant value doesn't give any coverage.
Description
This PR checks the value of the NOTHING_UP_MY_SLEEVE in the Poll test suite
Additional Notes
Hello :)
I am not entirely sure if this is the right approach to fix this issue but i figured the making the PR will be a good place to start. Please let me know what do you think. Any guidance will be appreciated for sure.
Related issue(s)
Fix #1153
Confirmation