Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typographical errors #1979

Closed
wants to merge 8 commits into from

Conversation

Pricstas
Copy link

This pull request addresses various grammar and typographical errors across multiple files in the repository.
The changes include the correction of improper articles ("a" vs. "an") and minor phrasing adjustments to improve code comments, documentation, and test descriptions.

Changes Overview

  1. apps/website/src/scripts/utils.ts:

    • Corrected "a index page" to "an index page".
  2. PoseidonFuncs.md:

    • Updated "A interface" to "An interface".
  3. Ballot.md:

    • Changed "Generate an hash" to "Generate a hash".
  4. proofs.ts:

    • Adjusted "a intel chip" to "an intel chip".
  5. storage.ts:

    • Replaced "a undefined" with "an undefined".
  6. ballot.test.ts:

    • Fixed "an hash" to "a hash".
  7. ballot.ts:

    • Updated "an hash" to "a hash".
  8. PCommand.ts:

    • Corrected "an mismatched" to "a mismatched".

Additional Notes

  • These changes are aimed at enhancing the clarity and professionalism of the documentation and codebase.
  • No functional changes were introduced.

Related Issues

No specific issues linked to this PR.


Confirmation


Summary of Commits

  • Fixed grammar in utility and domain objects files.
  • Corrected articles and minor phrasing inconsistencies across test cases and documentation.

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Dec 27, 2024 8:02pm

@0xmad
Copy link
Collaborator

0xmad commented Dec 27, 2024

While we appreciate you submitting this PR, we will be closing it to conform with our contributions guidelines https://maci.pse.dev/docs/contributing/ - cited: "We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation". We hope you see you contribute to the project, if in search for a task to take, please refer to our open issues, or contact the team.

@0xmad 0xmad closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants